search

Azure / container-apps-deploy-action

GitHub Action for building and deploying Azure Container Apps
MIT License
50 stars 30 forks source link

`Node.js 16 actions are deprecated. ` #97

Open afifurrohman-id opened 7 months ago

afifurrohman-id commented 7 months ago

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: azure/container-apps-deploy-action@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

onionhammer commented 5 months ago

Is container-apps-deploy-action deprecated?

Jordan-Afonso-OCC commented 4 months ago

@afifurrohman-id for

azure/login@v1

You must have a step in your workflow which uses this action v1 and you can then replace it with azure/login@v2

If not, check in the Set up job in your workflow if you can find something like : Getting action download info Download action repository 'azure/login@v1'

which means that one of your marketplace step that you use in your workflow uses the old version of this action. Try to update it if a new version is available or raise an issue on their repo.

about this :

azure/container-apps-deploy-action@v2

did someone plan to update node version of this action ??

afifurrohman-id commented 4 months ago

You must have a step in your workflow which uses this action v1 and you can then replace it with azure/login@v2

Thank you fyi, i didn't check if azure-login have v2.

yevhenii0bozhenko commented 4 months ago

Dear team, Could you please have a look at this line: https://github.com/Azure/container-apps-deploy-action/blob/02d045129c058b13312276b50a552834cf74e2af/action.yml#L144 Looks like it has been forgotten to update.

afifurrohman-id commented 4 months ago

Dear team, Could you please have a look at this line:

https://github.com/Azure/container-apps-deploy-action/blob/02d045129c058b13312276b50a552834cf74e2af/action.yml#L144

Looks like it has been forgotten to update.

It's easy to just update a string, but a significant version changes may contains breaking changes

yevhenii0bozhenko commented 4 months ago

@afifurrohman-id, it looks like the action is already using node version 20. It is just a description that is not being up to date: https://github.com/Azure/container-apps-deploy-action/blob/02d045129c058b13312276b50a552834cf74e2af/package.json#L27

afifurrohman-id commented 4 months ago

@afifurrohman-id, it looks like the action is already using node version 20. It is just a description that is not being up to date:

https://github.com/Azure/container-apps-deploy-action/blob/02d045129c058b13312276b50a552834cf74e2af/package.json#L27

That's just a library version, the problem itself not about the library, but the runtime itself.

https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runs-for-javascript-actions