search

Azure / container-apps-deploy-pipelines-task

Azure Pipelines Task (Release Candidate) for building and deploying Azure Container Apps
MIT License
6 stars 10 forks source link

Reorder AzureContainerApps main to enable early exit when imageToDeploy parameter is provided. #17

Closed jamesmacfd closed 1 year ago

jamesmacfd commented 1 year ago

Duplicate of https://github.com/microsoft/azure-pipelines-tasks/pull/17726 from main task repo.

cormacpayne commented 1 year ago

@jamesmacfd Hey James, apologies for delaying your PR -- we're working on syncing the stable task released in the microsoft/azure-pipelines-tasks repository with the latest changes in this RC repository, so as soon as we get that updated and merged, I'll loop back to this PR and make sure it gets in.

cormacpayne commented 1 year ago

@jamesmacfd Hey James, apologies for an even longer delay -- we just merged a PR that completely refactored the flow of the main method executed for the task, making it easier to follow and sectioning off different scenarios that users can target.

For the issue that your PRs target, this refactoring has resolved the issue as the pack CLI is now only installed when the scenario to build a runnable application image using the builder is targeted, seen here.

Your scenario for providing a pre-built image now has an independent flow that doesn't touch anything relating to building and/or pushing images, seen here.

This refactoring (and other changes) are now available in the 1.0.0 release of the RC task, and will soon be available in the stable task, so feel free to give it a try and let us know if you have any issues and concerns. We appreciate you opening the original set of PRs to get this realignment work in motion!