search

Azure / container-apps-deploy-pipelines-task

Azure Pipelines Task (Release Candidate) for building and deploying Azure Container Apps
MIT License
6 stars 10 forks source link

Why task is downloading aditional code? #3

Closed piterzet closed 1 year ago

piterzet commented 1 year ago

I run this task as a step within a pipeline which is using self-hosted agent (Ubuntu). Task crashes with log:

Unable to run provided bash command '(
curl -sSL "https://github.com/buildpacks/pack/releases/download/v0.27.0/pack-v0.27.0-linux.tgz" | tar -C /usr/local/bin/ --no-same-owner -xzv pack)'.
##[error]Unable to install pack CLI.
##[error]The process '/bin/bash' failed with exit code 2

After digging to your code I saw this.

Don't understand why it was done this way and I don't like this. IMHO please add prerequisites entry about Cloud Native Buildpacks and in your code just check if package is aviable.

cormacpayne commented 1 year ago

@piterzet Hey there -- apologies for the delayed response; this is a good call-out. We use Cloud Native Buildpacks to produce a runnable application image within the task for the user if they don't provide a Dockerfile to build or a previously built and push image, but we need to install the pack CLI for CNB in order to do so, which is what the script you mentioned above does. This should be called out in the prerequisites of the task so users know why the pack CLI is being installed, as well as a check for the CLI when the task is executing to determine whether or not we need to install it. Thanks for the report!

cormacpayne commented 1 year ago

@piterzet Hey there -- this issue is resolved in the latest release of the AzureContainerAppsRC task (0.1.8). Please feel free to let us know if there's anything else that you'd like for us to address with this issue in the future. Thanks!