Include the entire read response body and file save operation inside retry method - Githubissues

Azure / custom-script-extension-linux

Azure Custom Script Virtual Machine Extension :new:

Apache License 2.0

106 stars 32 forks source link

Include the entire read response body and file save operation inside retry method #212

Closed malhotrarohit closed 1 year ago

malhotrarohit commented 1 year ago

What operation are we performing on behalf of the customer?

Downloading the script files and saving them to locla disk

What part of this operation are we retrying on?

Just the HTTP download and that too only if status is not 200

What should we be retrying ideally?

The entire operation = HTTP request + streaming response + writing streamed bytes to local disk

This PR aims to make all parts of the operation retryable.