search

Azure / data-api-builder

Data API builder provides modern REST and GraphQL endpoints to your Azure Databases and on-prem stores.
https://aka.ms/dab/docs
MIT License
842 stars 169 forks source link

Release branch's commit ID is included in the version Assembly metadata #1456

Open severussundar opened 1 year ago

severussundar commented 1 year ago

Enabling deterministic builds appends the release branch's git commit ID to the assembly metadata.

So running dab --version outputs the below

image

Displaying the git commit ID is unnecessary from the user's perspective.

Investigate and come up with a fix to output just the (without including the git commit id hash)

Some options to consider:

  1. Possibility of just printing the yet have the git commit id in the assembly metadata.
  2. Possiblity of including the commit id in the assembly metadata in a field other than the version number
seantleonard commented 5 months ago

This is due to commandlineparser's AutoHelper. The changes needed can be inferred from the suggestions here: https://github.com/commandlineparser/commandline/issues/757#issuecomment-1005505288

Docs with examples where we would implement our own method which printed out the help text. I didn't want to bloat #2086 even further. This may not be that big of a change, but requires its own troubleshooting. https://github.com/commandlineparser/commandline/wiki/HelpText-Configuration