Adding Sql pool is warming up error code to list of transient exceptions - Githubissues

Azure / data-api-builder

Data API builder provides modern REST and GraphQL endpoints to your Azure Databases and on-prem stores.

https://aka.ms/dab/docs

MIT License

787 stars 142 forks source link

Adding Sql pool is warming up error code to list of transient exceptions #2241

Closed rohkhann closed 4 weeks ago

rohkhann commented 4 weeks ago

Why make this change?

Datawarehouse's can have cold start up issues leading to sql error: The SQL pool is warming up. Please try again. This is a transient exception and the recommendation is to just retry and connect back to the server:https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/relational-databases/errors-events/mssqlserver-42109-database-engine-error.md.

What is this change?

This change adds the error code for the Sql pool is warming up into the transient error code list, ensuring the retry logic comes into play if this error comes up. For the code please see: https://github.com/dotnet/efcore/blob/main/src/EFCore.SqlServer/Storage/Internal/SqlServerTransientExceptionDetector.cs

How was this tested?

Existing integration tests cover the logic for retry on transient exception codes.

rohkhann commented 4 weeks ago

/azp run