Azure / data-api-builder

Data API builder provides modern REST and GraphQL endpoints to your Azure Databases and on-prem stores.
https://aka.ms/dab/docs
MIT License
949 stars 197 forks source link

Hot Reload Validation #2405

Closed RubenCerna2079 closed 3 weeks ago

RubenCerna2079 commented 1 month ago

Why make this change?

This change fixes issue #2396

What is this change?

In order to validate the hot-reload, first, new logic was added to the RuntimeConfigLoader and FileSystemRuntimeConfigLoader, so when hot reload occurs, it updates the new states added to the loader which are isNewConfigDetected, isNewConfigValidated, and lastValidRuntimeConfig. Once the states are updated, it will try to parse and validate the new RuntimeConfig, in the case that it fails at any step of the way, the hot-reloading process will be canceled and the RuntimeConfig file will be changed so that it uses the information from lastValidRuntimeConfig so that the user can still use their last configuration without any problems.

How was this tested?

RubenCerna2079 commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago
Pull request contains merge conflicts.
RubenCerna2079 commented 1 month ago

/azp run

RubenCerna2079 commented 1 month ago

/azp run

RubenCerna2079 commented 1 month ago

/azp run

RubenCerna2079 commented 1 month ago

/azp run

aaronburtle commented 1 month ago

This is great and the way that you update with the Last Known Good will close this bug here: https://github.com/Azure/data-api-builder/issues/2418

So you can added the closes tag for that issue to the PR description.

Once you address the comments should be good to go.

RubenCerna2079 commented 1 month ago

/azp run

RubenCerna2079 commented 1 month ago

/azp run

RubenCerna2079 commented 1 month ago

/azp run

azure-pipelines[bot] commented 1 month ago
Pull request contains merge conflicts.
RubenCerna2079 commented 1 month ago

/azp run

RubenCerna2079 commented 1 month ago

/azp run

RubenCerna2079 commented 1 month ago

/azp run

RubenCerna2079 commented 1 month ago

/azp run

RubenCerna2079 commented 1 month ago

/azp run

RubenCerna2079 commented 1 month ago

/azp run

RubenCerna2079 commented 1 month ago

/azp run

Aniruddh25 commented 3 weeks ago

/azp run

RubenCerna2079 commented 3 weeks ago

/azp run

abhishekkumams commented 3 weeks ago

/azp run