search

Azure / data-api-builder

Data API builder provides modern REST and GraphQL endpoints to your Azure Databases and on-prem stores.
https://aka.ms/dab/docs
MIT License
949 stars 197 forks source link

Added End-To-End Test for Datasource Hot-Reload #2453

Closed RubenCerna2079 closed 5 days ago

RubenCerna2079 commented 2 weeks ago

Why make this change?

This change solves the issue #1866

What is this change?

Added an end-to-end test to ensure that DAB hot-reloads appropriately when there is a connection change from one database to another database (e.g. MSSQL to PostgreSQL). In order to make tests related to hot reload less flaky, we stopped using the sleep() function and added an event in FileSystemRuntimeConfigLoader, which triggers when hot reload is complete. This event is used by the tests in order to wait until hot reload finishes.

How was this tested?

RubenCerna2079 commented 2 weeks ago

/azp run

RubenCerna2079 commented 2 weeks ago

/azp run

abhishekkumams commented 2 weeks ago

Can you also add one more test where you update the connection string with invalid value and then change it to a valid value, with 200 response?

RubenCerna2079 commented 1 week ago

Can you also add one more test where you update the connection string with invalid value and then change it to a valid value, with 200 response?

I don't think we need this test, since the hot-reload has a last known good config file to go to when there is an error, so it will not change anything by trying to change the connection string to an invalid value. And a successful connection string change is already tested with the current test that I am working on.

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 1 week ago

/azp run

RubenCerna2079 commented 6 days ago

/azp run

RubenCerna2079 commented 6 days ago

/azp run

RubenCerna2079 commented 6 days ago

/azp run

RubenCerna2079 commented 6 days ago

/azp run

RubenCerna2079 commented 6 days ago

/azp run

RubenCerna2079 commented 6 days ago

/azp run

RubenCerna2079 commented 6 days ago

/azp run

RubenCerna2079 commented 6 days ago

/azp run

RubenCerna2079 commented 6 days ago

/azp run

RubenCerna2079 commented 6 days ago

/azp run

RubenCerna2079 commented 5 days ago

/azp run

RubenCerna2079 commented 5 days ago

/azp run

RubenCerna2079 commented 5 days ago

/azp run