Sql: Refactor Mock tests to provide better additional mocks

Azure / data-api-builder

Data API builder provides modern REST and GraphQL endpoints to your Azure Databases and on-prem stores.

https://aka.ms/dab/docs

MIT License

842 stars 169 forks source link

Sql: Refactor Mock tests to provide better additional mocks #353

Open Aniruddh25 opened 2 years ago

Aniruddh25 commented 2 years ago

In order to satisfy Mock test requirements, we had to add some default constructors/nullable properties. Mock tests should ideally be sending the required mocks so we don't have to keep nullable properties. This issue is to fix our tests to generate the right mocks.

seantleonard commented 1 year ago

Many updates have occurred since this issue was raised. In order to identify what changes need to occur, I am searching through our

Test Project -> Identify areas of where mock creation/usage can be made more efficient and simplified.
Service Project -> for interfaces / classes which surface constructors or method signatures that are nullable only for testing purposes.

Goal(s):

Reduce instances of Service project class/method signatures only utilized for testing purposes.

seantleonard commented 1 year ago

Moving out of open sourcing milestone since this is more of a generic refactor.