search

Azure / data-lake-adlstool

Azure Data Lake Store command-line tools in Java
Other
9 stars 10 forks source link

Consul template creds file #5

Closed grahamsk closed 7 years ago

grahamsk commented 7 years ago

At SwiftKey we use Consul Template (https://github.com/hashicorp/consul-template) in conjunction with VSTS to generate the data-lake-adlstool cred file from environment variables.

Submitting this PR just in case it's useful for someone else.

Let me know if you would like me to add more detail or different cred file types. I have only included a Service Principal based auth cred file.

msftclas commented 7 years ago

@grahamsk, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot

asikaria-msft commented 7 years ago

Thanks @grahamsk for the contribution. A template for the cred file is a great idea. Is it possible to add comments identifying this as a Consul Template file?

asikaria-msft commented 7 years ago

Also, identify in the filename that it is service principal based. I believe it is ok to add templates as needed by users - we can think about more template types if we see others asking for it.

Thanks again for contributing back.

grahamsk commented 7 years ago

Hi @asikaria-msft ,

I've made the requested changes. If you spot anything else do let me know and I'll happily modify.

asikaria-msft commented 7 years ago

Merged. Thanks @grahamsk!

grahamsk commented 7 years ago

Thank you guys for making such a great tool @asikaria-msft !