search

Azure / data-management-zone

Template to deploy the Data Management Zone of Cloud Scale Analytics (former Enterprise-Scale Analytics). The Data Management Zone provides data governance and management capabilities for the data platform of an organization.
MIT License
169 stars 87 forks source link

Feature Request: Remove AzureFirewallSubnet when not Deploying Azure Firewall #216

Closed jonathan-vella closed 2 years ago

jonathan-vella commented 2 years ago

For deployments which do not require Azure Firewall, we should remove the automated deployment of the AzureFirewallSubnet. There's no use for this /24 subnet.

marvinbuss commented 2 years ago

Thanks @jonathan-vella for submitting this. Let us look into that!

marvinbuss commented 2 years ago

Hi @jonathan-vella, Thanks for submitting this. I am currently evaluating the best way to implement this feature request. Due to the issue described here https://github.com/Azure/bicep/issues/2733 there is no clean way of implementing this. We either define each subnet as variable and then do a concat or we leave things as they are for now and then customers can remove subnets from the IaC if they are not required.

For the Data Management Zone, it is still quite easy as we only have two subnets at the moment, but for the Data Landing Zone it will get more messy as more subnets are created and we would have to define them as variables. Also, I want to make sure that we are consistent across Data Management Zone and Data Landing Zone. Do you have any preference wrt the options mentioned above? Looking forward to your feedback!

marvinbuss commented 2 years ago

Hi @jonathan-vella, Feel free to take a look at https://github.com/Azure/data-management-zone/pull/219 and share your thoughts.

jonathan-vella commented 2 years ago

Sure. Please allow me some time since I'm travelling all week this week.

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Marvin Buss @.> Sent: Tuesday, November 2, 2021 12:00:30 PM To: Azure/data-management-zone @.> Cc: Jonathan Vella @.>; Mention @.> Subject: Re: [Azure/data-management-zone] Feature Request: Remove AzureFirewallSubnet when not Deploying Azure Firewall (Issue #216)

Hi @jonathan-vellahttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjonathan-vella&data=04%7C01%7C%7C2e9e73a14e3c49f85a3d08d99de79b39%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637714440330330674%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=p%2BuYStlsLryrZ8wkIeKhwTeZZO8IQ%2BLun5%2BVu07U02k%3D&reserved=0, Feel free to take a look at #219https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fdata-management-zone%2Fpull%2F219&data=04%7C01%7C%7C2e9e73a14e3c49f85a3d08d99de79b39%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637714440330330674%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=xSSJFNuKM%2FMBg7r%2FavRrjP4zmcvYtPgEgQmriNPDG7k%3D&reserved=0 and share your thoughts.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fdata-management-zone%2Fissues%2F216%23issuecomment-957285367&data=04%7C01%7C%7C2e9e73a14e3c49f85a3d08d99de79b39%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637714440330340670%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=H2g4%2B0qaWGTMmQfywEGd64KtsBkp3FV%2BwLK1IKzl%2BEI%3D&reserved=0, or unsubscribehttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGE3LI3PJFKH7YLIE3YUDWLUJ6ZD5ANCNFSM5G6SZOTQ&data=04%7C01%7C%7C2e9e73a14e3c49f85a3d08d99de79b39%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637714440330340670%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=NM8CooJ8IqH%2Bry8xLmHtmwcnOzQBUQu72P7X0SgX1zk%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C2e9e73a14e3c49f85a3d08d99de79b39%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637714440330350662%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=aRIlYL3X6x%2F5YB422FRqV36NXDvxKA7pDJ5gIqwnTxQ%3D&reserved=0 or Androidhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C2e9e73a14e3c49f85a3d08d99de79b39%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637714440330350662%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=9hfgP1dZ0wNISx%2BEGJQYwB6IeDVBxY%2B7atsVpQU2DPE%3D&reserved=0.