search

Azure / doAzureParallel

A R package that allows users to submit parallel workloads in Azure
MIT License
107 stars 50 forks source link

Fix: Option to set maximum expiry date for task completion upload tokens #364

Open zerweck opened 4 years ago

zerweck commented 4 years ago

Proposed fix for #363

msftclas commented 4 years ago

CLA assistant check
All CLA requirements met.

zerweck commented 4 years ago

No Idea why Travis failed :/

zerweck commented 4 years ago

Looking at the build log, it doesn't seem like a problem related to my diff. Is it possible to just re-run the build?

brnleehng commented 4 years ago

Hey @zerweck

Thanks for the PR! Appreciate it -- can you also update the docs so other users can use it (https://github.com/Azure/doAzureParallel/blob/master/docs/52-azure-foreach-options.md)? I'll take a look into why the build is failing. I'm also taking a look at some other better namings of the parameter.

I'm leaning towards fileSasExpiryTime or containerSasExpiryTime instead of a maxDate.

Thanks, Brian