Azure / docker-login

GitHub action to log in to Azure Container Registry (ACR) or any private container registry
MIT License
110 stars 48 forks source link

Can not use the new docker/login version v1.0.1 #48

Closed mike-petersen closed 1 year ago

mike-petersen commented 1 year ago

Since the new version a few minutes ago, we get the following error:

`node:internal/modules/cjs/loader:936 throw err; ^

Error: Cannot find module '@actions/core' Require stack:

akbast commented 1 year ago

We are also getting the same error

amilochau commented 1 year ago

Hi, I have seen the same issue on my projects for a few minutes. I would prefer not to have to explicitly reference v1.0.0 in all my workflows...

thien-nguyenthanh commented 1 year ago

Yes. I also getting the same issue with azure/docker-login@v1 Error: Error: Cannot find module '@actions/core'

mike-petersen commented 1 year ago

Hi, I have seen the same issue on my projects for a few minutes. I would prefer not to have to explicitly reference v1.0.0 in all my workflows...

unfortunately the previous version is called only "v1". Due to that v1.0.0 does not even work :(

bamarch commented 1 year ago

Hi, I have seen the same issue on my projects for a few minutes. I would prefer not to have to explicitly reference v1.0.0 in all my workflows...

unfortunately the previous version is called only "v1". Due to that v1.0.0 does not even work :(

You can do @2faa66cfd1a1e8d02713b5df43a1f4da62872ec2

antimirov commented 1 year ago

Same error, started happening today

ehovaere commented 1 year ago

Anyone know what commit was tagged "v1" before one hour ago ?

ehovaere commented 1 year ago

Sorry just saw 2faa66cfd1a1e8d02713b5df43a1f4da62872ec2, thx @bamarch

akbast commented 1 year ago

I am getting the same error with 2fa...

Run azure/docker-login@2faa66cfd1a1e8d02713b5df43a1f4da62872ec2
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module '@actions/core'
mike-petersen commented 1 year ago

Hi, I have seen the same issue on my projects for a few minutes. I would prefer not to have to explicitly reference v1.0.0 in all my workflows...

unfortunately the previous version is called only "v1". Due to that v1.0.0 does not even work :(

You can do @2faa66cfd1a1e8d02713b5df43a1f4da62872ec2

Unfortunately this also does not seem to work. If you look under tags https://github.com/Azure/docker-login/tags it seems like the v1 tag is now also updated to the broken version v1.0.1

ChillyBots commented 1 year ago

@BALAGA-GAYATRI Can you get eyes on this? quite likely to have broken a lot downstream

ehovaere commented 1 year ago

Ok, so my question is still valid :) Anyone know what commit was tagged "v1" before one hour ago ?

akbast commented 1 year ago

https://github.com/Azure/docker-login/commit/7c3fbb89c5162a802bc3743389996c6a647bd5db this worked for us.

BALAGA-GAYATRI commented 1 year ago

Can you please check now?

bamarch commented 1 year ago

Anyone know what commit was tagged "v1" before one hour ago ?

Unclear what it was since the tags keep getting changed, seems like going back far enough in time is working:

https://github.com/Azure/docker-login/commit/7c3fbb89c5162a802bc3743389996c6a647bd5db

bamarch commented 1 year ago

Can you please check now?

I've just ran using @v1 and it works in my environment, thank you for the quick attention

akbast commented 1 year ago

v1 is working now.

BALAGA-GAYATRI commented 1 year ago

I have chacked v1.0.1 is also working now. Please re-run once and confirm

mike-petersen commented 1 year ago

I have chacked v1.0.1 is also working now. Please re-run once and confirm

Thanks. Looks like it is fixed.