search

Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.92k stars 395 forks source link

Change imagePullPolicy on `draft init` canary deployments to "Always" #312

Closed bacongobbler closed 7 years ago

bacongobbler commented 7 years ago

This change was present in charts/ but not in the codebase. #247 should solve this in the future, but this resolves an issue where users were not seeing the latest version of their canary images bring run.

msftclas commented 7 years ago

@bacongobbler, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot

codecov-io commented 7 years ago

Codecov Report

Merging #312 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #312   +/-   ##
=======================================
  Coverage   29.54%   29.54%           
=======================================
  Files          30       30           
  Lines        1892     1892           
=======================================
  Hits          559      559           
  Misses       1255     1255           
  Partials       78       78
Impacted Files Coverage Δ
cmd/draft/installer/install.go 0% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c74046...efc630b. Read the comment docs.