search

Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.92k stars 395 forks source link

ref(pkg/draft): remove ondraft val #317

Closed michelleN closed 7 years ago

michelleN commented 7 years ago

We're not using this any where right now so removing to prevent confusion!

msftclas commented 7 years ago

@michelleN, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot

bacongobbler commented 7 years ago

This was being used in another project, but it was to work around ingress rules. Now with ingress.enabled as a value, we can check that instead. LGTM

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e73923e). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #317   +/-   ##
=========================================
  Coverage          ?   29.39%           
=========================================
  Files             ?       30           
  Lines             ?     1902           
  Branches          ?        0           
=========================================
  Hits              ?      559           
  Misses            ?     1265           
  Partials          ?       78
Impacted Files Coverage Δ
pkg/draft/context.go 78.04% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e73923e...7641f12. Read the comment docs.