Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.92k stars 395 forks source link

Cant use draft with csharp #392

Closed profesor79 closed 6 years ago

profesor79 commented 7 years ago

Hi guys, is there a way to get why daraft cannot pack c#? And also why c# is recognized as xml?

draftcsharp

I checked it with go language and it works, so this is not a local setup issue I suppose

image

bacongobbler commented 7 years ago

Hey @profesor79! Can you give us more information on what version of draft you're running?

bacongobbler commented 7 years ago

Curious that in your first screenshot it looks like the path it's looking for is ...\.draft\packs\ack=csharp. I haven't seen that before.

profesor79 commented 7 years ago

hi @bacongobbler , I pulled lastest yesterday.

 draft version
Client: &version.Version{SemVer:"v0.7.0", GitCommit:"0054537f5fe2561f8dc0fe3cca0fc5970f62562d", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v0.7.0", GitCommit:"0054537f5fe2561f8dc0fe3cca0fc5970f62562d", GitTreeState:"clean"}

have windows 10 Enterprise

Let me know how I can dig some more info for you guys

bacongobbler commented 7 years ago

Hmm. draft create works just fine for me using the example ASP.NET application.

PS C:\Users\mafishe\go\src\github.com\Azure\draft\examples\csharp> draft create
--> Draft detected the primary language as csharp with 84.861307% certainty.
--> Ready to sail

Do you have a public repository that we can use to test against?

bacongobbler commented 7 years ago

One PR that may assist with the language being detected as XML would be #344. If there is a large amount of code in your .csproj files then linguist is going to detect that a large majority of your codebase is written in XML. Once #344 is finalized and merged, you can fix this by writing out the following .gitattributes file in the root of your application:

*.csproj linguist-language=csharp
bacongobbler commented 6 years ago

ping, any news on this front?

profesor79 commented 6 years ago

pong - will try to check that tomorrow and will revert here.

bacongobbler commented 6 years ago

I'm going to close this issue due to inactivity and due to lack of being able to reproduce the issue locally, but please feel free to re-open and report back once you get an idea how it occurred. Thanks!