search

Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.92k stars 395 forks source link

draft create does not copy the .dockerignore file #427

Closed jumal closed 6 years ago

jumal commented 6 years ago

When doing for example a "draft create -p java" the .dockerignore file present in the Java starter pack is not copied to the project

michelleN commented 6 years ago

Hey @jumal - Thanks for pointing this out. It looks like we're only copying the charts/ dir and the Dockerfile. We should either add .dockerignore to the list of files we copy OR we can choose to copy anything in the pack over to the application directory. Would be interested in what you think.

Also, thoughts? @bacongobbler @fibonacci1729 I'd opt for copying everything over. That'll make it easier to support scripts/hooks later on.

jumal commented 6 years ago

Hi Michelle. Thanks for your quick reply. I would personally favour the approach copying everything. I currently have directories in my custom starter packs that need to be copied via scripting. Having Draft copying everything would definitively help

bacongobbler commented 6 years ago

This would be a great addition.

bacongobbler commented 6 years ago

Something brought up in https://github.com/Azure/draft/issues/549 is the ability to copy the contents of non-chart directories in the pack as well, which would be useful to bring into #453.