Closed jstrachan closed 6 years ago
BTW I just submitted this PR that demonstrates draft create
fails on a canonical Spring Boot project
https://github.com/Azure/draft/pull/489
With the above PR merged you can demonstrate this issue via:
cd examples/examples-spring-boot
draft create
You can create your own spring boot example with a few clicks on: http://start.spring.io/ - I did not modify the code in any way from whats generated from start.spring.io)
FWIW Spring Boot is probably the most common framework for building microservices with Java and should be something draft create
can cope with
I just tried the pack detection on a simple spring boot java app via
draft create
and gotWith debug I saw:
Its quite common to have some shell scripts and sometimes not huge amounts of Java code / POM files etc.
In this particular case its due to spring boot apps often including shell scripts to wrap invoking maven + gradle - which can be larger than the hello world Java source code ;)
So I wonder if a nicer approach would be to
If folks are happy with the above I'd be happy to submit a PR. Would love draft to just work OOTB with any Spring Boot app generated from: http://start.spring.io/ for example!