search

Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.92k stars 395 forks source link

draft create --pack=foo does not copy the .dockerignore from the pack #477

Closed jstrachan closed 6 years ago

jstrachan commented 6 years ago

with a blank java project and typing:

draft  create --pack=github.com/Azure/draft/packs/java

there's no .dockerignore file copied across, despite them being one in the pack at ~/.draft/packs/github.com/Azure/draft/packs/java/.dockerignore.

While the build still works, it means that this dockerfile line https://github.com/Azure/draft/blob/master/packs/java/Dockerfile#L3 will copy all git history + target dir (so all pervious builds/tests/results/logs etc) which slows down the docker build.

bacongobbler commented 6 years ago

closing as a duplicate of #427, which will be fixed via #453.