Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.92k stars 395 forks source link

prompt for user input on `draft plugin remove` #553

Closed bacongobbler closed 6 years ago

bacongobbler commented 6 years ago
><> draft plugin install https://github.com/bacongobbler/draft-init-minikube
Installed plugin: init-minikube
><> draft plugin remove init-minikube
Removed plugin: init-minikube

Instead of making auto-accepting user input, we should probably prompt and gate it behind an --auto-accept or -y flag. That way it's one extra step from accidentally removing a plugin

michelleN commented 6 years ago

Is there a precedent for having this kind of gate? I only ask because I'm partial to have the user take the least amount of steps possible to achieve a goal. I can understand putting a gate on something that may be detrimental for a production set up (example: deleting a Helm release) but I don't think deleting a plugin is a big deal. What do you think?

bacongobbler commented 6 years ago

Makes sense. Since we're not actually removing resources from the cluster this is a good default. Closing!