Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.92k stars 396 forks source link

Lowercase "sirupsen" imports #578

Closed jzelinskie closed 6 years ago

jzelinskie commented 6 years ago

If I import Go from this project, I'm forced to name my imports github.com/Sirupsen/logrus or else receive a compiler error:

formats.go:11:2: case-insensitive import collision: "github.com/sirupsen/logrus" and "github.com/Sirupsen/logrus"

The logrus project has made a note that eventually everyone should be using all lowercase for their imports.

It's very likely that one of Draft's dependencies is reason why it has to use this capitalization.

Hopefully by tracking the issue, we can convince others to lowercase their imports.

bacongobbler commented 6 years ago

This can be closed once #573 is merged :)

bacongobbler commented 6 years ago

closed via #573