Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.92k stars 396 forks source link

[Draft .12]: connection "sticks open" across clusters, terminals #624

Closed squillace closed 6 years ago

squillace commented 6 years ago

repeatedly running Draft against minikube, with and without registry config, and then switching to AKS westus2 cluster. Ubuntu 16.04, Unity/Terminology as terminal/shell is oh my zsh.

CTRL-C does not terminate the "connection". restarting terminal doesn't shake it, restarting minikube doesn't shake it. That's one tough connection. It'd be fine if it was accurate and it restated what port the active connection was on -- but I don't believe it's true. Does not fall over if I change clusters.

image

squillace commented 6 years ago

Update: I'm able to torch the connection if I destroy the artifacts in the app and rerun draft create. Then the connection recreates successfully.

radu-matei commented 6 years ago

There are a couple of things here:

  1. if your deployment template has at least one containerPort, the connection message should tell you where to connect and on what port - something like Connect to go:8080 on localhost:8080. We should figure out why no ports are forwarded in your case.

  2. the fact that you see Your connection is still active. the first time you connect is tackled in #626, and you should see that message after 5 minutes, not when connecting.

So the experience will be something like:

Connect to go:8080 on localhost:8080
[go]: + exec app
<other logs from the app>

<5 minutes later...>
Your connection is still active.
Connect to go:8080 on localhost:8080

Thoughts?

radu-matei commented 6 years ago

@squillace - do you still see the issue? Can we close this?

Thanks!

bacongobbler commented 6 years ago

closing until otherwise instructed to re-open. :)