Closed radu-matei closed 6 years ago
To test:
$ helm install stable/mysql --name mysql $ draft delete mysql
You will see an error that it didn't find any objects to delete from the ConfigMaps storage, but it will delete the Helm release.
The fix to simply invert the order of those two statements.
// delete helm release _, err = helmClient.DeleteRelease(app, helm.DeletePurge(true)) if err != nil { return errors.New(grpc.ErrorDesc(err)) } // delete Draft storage for app store := configmap.NewConfigMaps(client.CoreV1().ConfigMaps(tillerNamespace)) if _, err := store.DeleteBuilds(context.Background(), app); err != nil { return err }
Is there anything else that should be taken into consideration?
To test:
You will see an error that it didn't find any objects to delete from the ConfigMaps storage, but it will delete the Helm release.
The fix to simply invert the order of those two statements.
Is there anything else that should be taken into consideration?