search

Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.92k stars 396 forks source link

rename --config/-f flag on draft init #679

Open michelleN opened 6 years ago

michelleN commented 6 years ago

670 adds a flag on draft init that allows you to pass a toml file indicating which plugins and pack repositories you'd like to add/override when setting up draft. This makes it easier for orgs/teams that want to use custom plugins or their own draft pack repositories and don't want to do the manual draft plugin install and draft pack-repo add steps for each item.

--config/-f was put in for a quick mvp release of that functionality but we may want to think about if that is the right name for the flag at all. config is very overloaded. Should it be --custom or --defaults or --overrides or something else entirely?

If anyone has any thoughts here, they would be greatly appreciated.

This is also a great first issue for anyone looking to contribute. Bonus points for adding tests. :)

jessfraz commented 6 years ago

okay so I need to play with the tool a bit before I have opinions on the naming of flags :)

squillace commented 6 years ago

--custom-toml :-) --custom-app-config

bhavin192 commented 5 years ago

Hey folks, do we have any preference on this one? I would like to do the required change :) How about --config-file, --custom-config or --custom-config-file (really long flag)