Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.92k stars 395 forks source link

`draft init` fails on master due to fetching incorrect version URL #687

Closed bacongobbler closed 6 years ago

bacongobbler commented 6 years ago

relating to #682, the get scripts were changed to fetch using the plugin version. the value in plugin.yaml uses "x.y.z" as the version format rather than "vx.y.z" format, causing the get script to fetch the wrong URL:

><> ./bin/draft init
Installing default plugins...
Downloading https://azuredraft.blob.core.windows.net/draft/pack-repo-0.4.0-linux-amd64.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   215  100   215    0     0    552      0 --:--:-- --:--:-- --:--:--   552
tar: This does not look like a tar archive

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
!!! Failed to install draft-pack-repo
!!! For support, go to https://github.com/draftcreate/draft-pack-repo.
Error: plugin install hook for "pack-repo" exited with error

https://github.com/draftcreate/draft-pack-repo/pull/20 fixes this problem, but we'll need to cut a v0.4.1 with this fix.