remove the embedded Azure SDK from Draft once ACR Build is in azure-sdk-for-go

Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.

https://draft.sh

MIT License

3.92k stars 395 forks source link

remove the embedded Azure SDK from Draft once ACR Build is in azure-sdk-for-go #694

Open bacongobbler opened 6 years ago

bacongobbler commented 6 years ago

refs discussion in #691

ehotinger commented 6 years ago

@bacongobbler ACR Build is in azure-sdk-for-go and published in /preview so this item is unblocked now.

Ref: https://github.com/Azure/azure-sdk-for-go/tree/master/services/preview/containerregistry/mgmt/2018-02-01/containerregistry

There should be no major breaking changes from the work you did earlier in #691 but the models may be ever-so-slightly different since I believe you hand-crafted a few properties like DockerImages?

bacongobbler commented 6 years ago

Yeah, we'll also need to retain some things like util.go until we contribute that upstream. Thanks for the heads up!