Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.93k stars 397 forks source link

Proposal: pull default draft packs into its own repo #698

Open bacongobbler opened 6 years ago

bacongobbler commented 6 years ago

Because of the current repository setup, when draft init is called it clones all of Azure/draft. This causes draft pack-repo to list all of the packs in their test directories:

C:\Users\mafishe\go\src\github.com
λ draft pack-repo list
github.com/Azure/draft
github.com/Azure/draft/cmd/draft/testdata/drafthome
github.com/Azure/draft/cmd/draft/testdata/drafthome/packs/github.com/Azure/draft
github.com/Azure/draft/pkg/draft/pack/repo/installer/testdata/packdir/defaultpacks
github.com/Azure/draft/pkg/draft/pack/repo/testdata
github.com/Azure/draft/pkg/draft/pack/repo/testdata/packs/github.com/testOrg1/testRepo1
github.com/Azure/draft/pkg/draft/pack/repo/testdata/packs/github.com/testOrg1/testRepo2

We should pull the default packs into a separate repository such that draft init only fetches the files it needs, rather than the entire codebase.

michelleN commented 6 years ago

+100 sounds great. Let's create a packs repo in github.com/draftcreate?

bacongobbler commented 6 years ago

SGTM. Let's figure out the CLA stuff first then sync up on that. :)

squillace commented 6 years ago

YES. Also, I'd like it if the new default draft packs now add in debug tomls for those langs we have working happily. node/go/ for now, soon java and dotnetcore