Progress messages garbled during "draft up" on Windows

Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.

https://draft.sh

MIT License

3.93k stars 397 forks source link

Progress messages garbled during "draft up" on Windows #746

Closed mlgibbons closed 6 years ago

mlgibbons commented 6 years ago

When I run a "draft up" on Windows 7 I see garbled characters in both in CMD and PowerShell.

radu-matei commented 6 years ago

Hi, and thanks for pointing this out!

I think #721 addresses this exact issue. If you could try the fix there and let us know if it solves it (as I don't have access to a Windows 7 machine), it would be great!

Thanks!

mlgibbons commented 6 years ago

Sure. Any tips on how to build draft on Windows 7? I've not used Go before but it's on my list of things to learn so happy to use this as a vehicle to do that.

bacongobbler commented 6 years ago

To be honest it's probably best to use the pre-compiled canary release instead. A lot of the development process centers around macOS/Linux as the development machine of choice which is then cross-compiled to Windows.

If you'd like to use a pre-compiled release of Draft, you can use the canary releases to test this out :) Canary releases of the Draft client for Windows can be found here: https://azuredraft.blob.core.windows.net/draft/draft-canary-windows-amd64.zip

mlgibbons commented 6 years ago

Ah. I did wonder if cross-compiling was the normal way of doing Windows builds.

Test looks good. Screenshot is below.

One minor point to note is the square betweeen the "SUCCESS" and the timing which doesn't quite look right.

Previous version looked like this

bacongobbler commented 6 years ago

Yeah that's the emojis which are being tracked in #304 so we can go ahead and close this :)