search

Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.93k stars 397 forks source link

rename tasks to hook #763

Open michelleN opened 6 years ago

michelleN commented 6 years ago

the term hooks seem to be more intuitive as you think of them as running once. The term tasks as was pointed out to me might confuse someone about how often these tasks run and if they run at certain intervals.

teaguecole commented 6 years ago

So this would just be a massive refactor, essentially finding occurrences of task/tasks etc and renaming. I feel like this would be a pretty big change for both user and developer, but since this experimental, I assume it doesn't have a massive impact. Seems pretty straight forward to do. I would have to rename pkg/tasks and the files inside, and then find everything that uses tasks package and refactor it to use hooks package etc. If you give me a thumbs up, I will do this.

FreddosaurusRex commented 5 years ago

i took a crack at this for Hacktoberfest. it's my 2nd PR ever so hopefully it's all good in the hood. if not, i'll fix it!

also, @michelleN you are awesome. i ended up following you on twitter based on some other MSFT employee tweet. i saw the username and didn't connect the 2 at first. keep doing great things. :)