Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.92k stars 397 forks source link

[Bug] Version of rjeczalik/notify fails linting and builds on darwin/amd64 #774

Closed jgleonard closed 6 years ago

jgleonard commented 6 years ago
 $ go version
go version go1.10.2 darwin/amd64
$ make test
scripts/lint.sh
Manadatory Linters: These must pass
vendor/github.com/rjeczalik/notify/watcher_fsevents_cgo.go:51::error: cannot use refZero (type int) as type *_Ctype_struct___CFAllocator in argument to func literal (vet)
vendor/github.com/rjeczalik/notify/watcher_fsevents_cgo.go:165::error: cannot use refZero (type int) as type *_Ctype_struct___CFAllocator in argument to func literal (vet)
vendor/github.com/rjeczalik/notify/watcher_fsevents_cgo.go:166::error: cannot use refZero (type int) as type *_Ctype_struct___CFAllocator in argument to func literal (vet)
Optional Linters: These should pass
pkg/local/local.go:208:1:warning: exported method App.GetPodNames should have comment or be unexported (golint)
pkg/tasks/tasks.go:14:2:warning: exported var ErrNoTaskFile should have comment or be unexported (golint)
pkg/tasks/tasks.go:18:2:warning: exported const PreUp should have comment (or a comment on this block) or be unexported (golint)
pkg/tasks/tasks.go:23:6:warning: exported type Tasks should have comment or be unexported (golint)
pkg/tasks/tasks.go:29:6:warning: exported type Result should have comment or be unexported (golint)
pkg/tasks/tasks.go:53:1:warning: exported method Tasks.Run should have comment or be unexported (golint)
make: *** [test-lint] Error 1
bacongobbler commented 6 years ago

closed via #775