Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.92k stars 397 forks source link

`draft create` does not respect file permissions in packs #816

Open omnilinguist opened 6 years ago

omnilinguist commented 6 years ago

After skimming through the existing packs, it looks like most or all of them don't have executables, which could explain this bug I found: if a file in a pack is marked as an executable, draft create -ping it drops the executable bit in the resulting file structure. To express this more generally, file permissions from draft packs should be preserved by draft create.

squillace commented 6 years ago

That is a great thing to have found! Thank you.

omnilinguist commented 6 years ago

...and, in an ironic twist, the reverse was discovered happening inside charts/[service-name]/templates: _helpers.tpl, together with all *.yaml files, have gotten the executable bit added in the draft created file structure, where it was not present in the pack!