search

Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.92k stars 397 forks source link

Feature Request: Add ability to specify array of helm chart values files #856

Open dm3ch opened 5 years ago

dm3ch commented 5 years ago

It would be great to have ability to specify array of values files for helm chart in draft toml config.

For example it could be needed for working on application in public git repository and keep values.yaml with not sensitive params and have second values files with sensitive params ignored by git. So people could see in repo properties required by chart but not see sensitive data

maximbaz commented 5 years ago

Related: #818

zoidyzoidzoid commented 5 years ago

So I've been looking at https://github.com/Azure/draft/issues/818 and this ticket, since I think it'd be a cool thing to contribute.

The place where Helm merges values files is in cmd/helm/install.go, and I've been looking into how Draft loads values files, but I'll try start working on a PR sometime this week.

radu-matei commented 5 years ago

Hey, @zoidbergwill! Let us know if you have any questions, we'd be happy to help :)

veeramarni commented 5 years ago

Wondering if there is any progress on this issue. It is quite a reasonable requirement when we have pipelines to deploy already built docker images to another environment without having to build the images again.

zoidyzoidzoid commented 5 years ago

Whoops, I disappeared. The last month has been a bit busier then expected. Gonna take a look at this today.

maximbaz commented 5 years ago

FYI, @zoidbergwill has already sent out an initial PR (thanks!): #899

zoidyzoidzoid commented 5 years ago

Please feel free to comment on it. I'll work on adding test coverage this weekend.