search

Azure / draft-classic

A tool for developers to create cloud-native applications on Kubernetes.
https://draft.sh
MIT License
3.92k stars 397 forks source link

add draft check command #910

Open michelleN opened 5 years ago

michelleN commented 5 years ago

like the linkerd check command, ensuring all systems go

bjornmagnusson commented 5 years ago

God yes! I´m so impressed by how it works in Linkerd. I would be down to help out with this. What are your thoughts about this for draft? check that k8s api / draft config setup / helm is available on working? or completely different? :)

michelleN commented 5 years ago

yes exactly!! Generally for features, we aim to write a Draft Enhancement Proposal/DEP before starting so everyone is on the same page about the feature. If you could take a stab at writing a DEP first, that would be awesome. If we don't want it to be top-level, we can also make a draft check plugin first. Either approach is fine in my opinion but we'll need buy-in from the other core maintainers to make this a top level command first. cc/ @fibonacci1729 @bacongobbler @radu-matei

Thank you!

bacongobbler commented 5 years ago

I'd love to have an "all systems nominal" check command baked right into the tool. A DEP would be great so we can figure out what parts of the system we need to check and how that'd look from a UX perspective. That way we can also explain what purpose draft check intends to solve (and more importantly what it does not intend to solve).

Let us know if you need any help!

bjornmagnusson commented 5 years ago

Sure thing, will do that. Thanks for the pointer. Makes sense