search

Azure / draft

A day 0 tool for getting your app on k8s fast
MIT License
515 stars 61 forks source link

[fix] Ensure last prompt gets default value #134

Closed rguptar closed 2 years ago

rguptar commented 2 years ago

If the user does not provide a value for the last prompt for a given config, the default value is not set for that variable.

Minimal Repro:

pip install Django
django-admin startproject mysite && cd mysite
draft create --dockerfile-only
# enter on each prompt

Actual Behavior: Dockerfile starts with FROM python:

Expected behavior: Dockerfile starts with FROM python:3.

davidgamero commented 2 years ago

@rguptar thank you for the fix! i was able to immediately repo and confirm the functionality LGTM

imiller31 commented 2 years ago

@rguptar we require all commits to be GPG signed and verified, we'll be able to merge once that is fixed

rguptar commented 2 years ago

@rguptar we require all commits to be GPG signed and verified, we'll be able to merge once that is fixed

Noted! I've updated the commit to be signed.

davidgamero commented 2 years ago

@rguptar unfortunately i still don't see the verified tag next to your commit, can you try signing it again?

davidgamero commented 2 years ago

thanks! LGTM