github action jobs must be listed by name to be required for PRs to merge, and since we have over 100 in draft across all of the languages and deployment types we can't list them all in a branch protection rule.
creating a new job that needs all of the other jobs would allow us to require just the new "summary" job, blocking PRs until every step has passed.
currently, PRs can be merged while integrations are running as long as approvals are in, even if the tests haven't finished as long as they haven't failed.
Type of change
[x] New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).
[x] tested by running the new steps on this pr branch
Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
davidgamero
commented
1 year ago
Description
github action jobs must be listed by name to be required for PRs to merge, and since we have over 100 in draft across all of the languages and deployment types we can't list them all in a branch protection rule.
creating a new job that needs all of the other jobs would allow us to require just the new "summary" job, blocking PRs until every step has passed. currently, PRs can be merged while integrations are running as long as approvals are in, even if the tests haven't finished as long as they haven't failed.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).
Checklist: