Azure / draft

A day 0 tool for getting your app on k8s fast

MIT License

493 stars 58 forks source link

set image pull policy to always #179

Closed davidgamero closed 1 year ago

davidgamero commented 1 year ago

Description

Change image pull policy to always continuing work from #153 since drifting

Fixes # (issue) Feature # (details)

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

davidgamero commented 1 year ago

looks like the integrations are failing due to the fact that we don't push the image to a registry in the minikube tests so it crashloopbackoffs

most likely fix is just pushing to the local registry and then specifying the local registry in the IMAGENAME to clearly pull it back down

davidgamero commented 1 year ago

by updating the image pull policy to always, users will encounter the same change: namely that they won't be able to spin up a minikube cluster for local development without a custom registry as well.

If we want to continue supporting that use we could improve our automated image name configuration to use a local registry. Either way- this will require more than just updating the templates to get it working

sabbour commented 1 year ago

they won't be able to spin up a minikube cluster for local development without a custom registry as well. @davidgamero where would they be pulling images from onto their minikube cluster otherwise? Are we talking about developers/contributors of draft, or developers using draft?

davidgamero commented 1 year ago

they won't be able to spin up a minikube cluster for local development without a custom registry as well. @davidgamero where would they be pulling images from onto their minikube cluster otherwise? Are we talking about developers/contributors of draft, or developers using draft?

developers using draft can currently build the dockerfile locally, and then it will be cached and they can use it in minikube to test the deployments, but with pull:always it will require they push the image even when testing locally, so they can't edit the image without pushing to a registry.

this is probably an acceptable tradeoff in exchange for enforcing a best practice, but worth noting