Azure / draft

A day 0 tool for getting your app on k8s fast
MIT License
493 stars 58 forks source link

generate-workflow docker build context flag #201

Closed aamgayle closed 1 year ago

aamgayle commented 1 year ago

Description

Adds docker build context flag to generate-workflow command

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

Checklist:

aamgayle commented 1 year ago

🎉🪄 LGTM - some thoughts - does this require any command helper update or az-cli impact? It also seems some build is failing as part of commit checks, thanks heaps.

I know that some of the unit tests had to add the BUILDCONTEXTPATH to their flagValuesMap or else they'd fail due to the prompt for the build context appearing with no way to input. If a test or something like that runs into a similar situation for either of those then I could see it impacting it. Otherwise, it shouldn't affect them at all!