Azure / draft

A day 0 tool for getting your app on k8s fast
MIT License
515 stars 61 forks source link

Additional unit tests for generate-workflow #202

Closed bosesuneha closed 1 year ago

bosesuneha commented 1 year ago

Description

Added negative test cases for increasing test coverage of pkg/workflows/workflows.go

Fixes # (issue) Feature # (details)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

Checklist:

bosesuneha commented 1 year ago

:shipit: 👍 Thanks for ping & LGTM. Long run, table-driven test are well recommended and for repetitive function output we could alway move to it but it will involve minor refactor. Example : https://gobyexample.com/testing-and-benchmarking

@Tatsinnit Thanks, will try to incorporate more table-driven tests going forward.