A previous image change updated the default tag to use the image gradle with tag jdk11, which doesn't specify a gradle version. Our demo repo uses gradle 7, so we need to specify this in the docker image tag by changing it to 7-jdk11.
Long-term it could be beneficial to add better parsing to draft that allows us to detect which version of gradle a repo is using, since using the wrong version of gradle will prevent the image from building
The image tag can take a both values in the format <GRADLE VERSION>-jdk<JDK-VERSION>
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.
[x] Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Existing integration tests now pass with the updated image
Checklist:
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
Description
Specify gradle version in the image tag with jdk
A previous image change updated the default tag to use the image
gradle
with tagjdk11
, which doesn't specify a gradle version. Our demo repo uses gradle 7, so we need to specify this in the docker image tag by changing it to7-jdk11
.Long-term it could be beneficial to add better parsing to draft that allows us to detect which version of gradle a repo is using, since using the wrong version of gradle will prevent the image from building The image tag can take a both values in the format
<GRADLE VERSION>-jdk<JDK-VERSION>
Fixes # (issue) Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Existing integration tests now pass with the updated image
Checklist: