Azure / draft

A day 0 tool for getting your app on k8s fast
MIT License
515 stars 61 forks source link

gradle specific version in dockerfile #208

Closed davidgamero closed 1 year ago

davidgamero commented 1 year ago

Description

Specify gradle version in the image tag with jdk

A previous image change updated the default tag to use the image gradle with tag jdk11, which doesn't specify a gradle version. Our demo repo uses gradle 7, so we need to specify this in the docker image tag by changing it to 7-jdk11.

Long-term it could be beneficial to add better parsing to draft that allows us to detect which version of gradle a repo is using, since using the wrong version of gradle will prevent the image from building The image tag can take a both values in the format <GRADLE VERSION>-jdk<JDK-VERSION>

Fixes # (issue) Feature # (details)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Existing integration tests now pass with the updated image

Checklist: