Azure / draft

A day 0 tool for getting your app on k8s fast
MIT License
515 stars 61 forks source link

changes to detect jre version from build.gradle #214

Closed hsubramanianaks closed 1 year ago

hsubramanianaks commented 1 year ago

Description

This PR is to include gradle wrapper to draft flow and detect the defaults from build.gradle for java projects.

Fixes # (issue) Feature # (details) This PR is to include gradle wrapper to draft flow and detect the defaults from build.gradle for java projects.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

Checklist:

Tatsinnit commented 1 year ago

☕️🥷 please note- seems like there is 404 when downloading draft cli, integration test might need some re-check here: (complete hunch and it should be tested is that might be os-arch for max for that latest more is not there. Thanks heaps 🙏

💡although I am not able to see and direct relation.

IMG_5253

hsubramanianaks commented 1 year ago

☕️🥷 please note- seems like there is 404 when downloading draft cli, integration test might need some re-check here: (complete hunch and it should be tested is that might be os-arch for max for that latest more is not there. Thanks heaps 🙏

💡although I am not able to see and direct relation.

IMG_5253

@Tatsinnit Thanks for pointing it out, seems like it is intermittent, it passed previously and client version is not null , weird. I will check and fix it in another PR :)

https://github.com/Azure/draft/actions/runs/5223305355/jobs/9429991236

hsubramanianaks commented 1 year ago

Closing this as it is taken care in another PR 218