Azure / draft

A day 0 tool for getting your app on k8s fast
MIT License
514 stars 61 forks source link

Changes in correlation with new GH Action Permission Changes. #242

Closed Tatsinnit closed 8 months ago

Tatsinnit commented 8 months ago

These changes are made in correlation with the following changes coming soon in the GH actions permissions. Please take a kind look. β€οΈπŸ™β˜•οΈ

To start with going with the most safest option with read only permission, for publish we need the write for content. Given this will spread pretty soon lets try this out and I will gradually open similarity changes in other repos I know.

Screenshot 2024-01-22 at 11 41 38β€―AM

For, release only workflow Sample test if we do content: read for publish we will get some error like this which I tested in my fork for other project.

Screenshot 2024-01-22 at 11 27 19β€―AM

Thank you. β€οΈπŸ™

davidgamero commented 8 months ago

we will need similar changes in https://github.com/Azure/homebrew-draft to allow the homebrew package to build successfully too, testing that interaction between repos in forks would give us better confidence in the perms

Tatsinnit commented 8 months ago

we will need similar changes in https://github.com/Azure/homebrew-draft to allow the homebrew package to build successfully too, testing that interaction between repos in forks would give us better confidence in the perms

Sounds good, let me fire/fork that up, after few things I have inlined (will open a PR by EOD πŸ›ΊπŸ”” 🀞 ), thanks.