Azure / draft

A day 0 tool for getting your app on k8s fast
MIT License
493 stars 58 forks source link

Added SDK calls to the getAppObjectId function #260

Closed Vidya2606 closed 2 months ago

Vidya2606 commented 3 months ago

Description

Migrating getAppObjectId function from using the Azure CLI calls to SDK calls from azure-sdk-for-go.

Screenshot 2024-03-28 at 11 45 25 AM

Fixes # (issue)

Fixes # (issue) Feature # (details)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

Checklist:

OliverMKing commented 2 months ago

unit tests are failing. seems like you need to run go mod tidy or do something else with imports

OliverMKing commented 2 months ago

unit tests are failing. seems like you need to run go mod tidy or do something else with imports

why does Draft vendor? that's causing problems

davidgamero commented 2 months ago

unit tests are failing. seems like you need to run go mod tidy or do something else with imports

why does Draft vendor? that's causing problems

this is a good question we may not need to vendor and then we can avoid these issues

davidgamero commented 2 months ago

271 will unblock these tests

davidgamero commented 2 months ago

okay should work when the updated main tests finish