Azure / draft

A day 0 tool for getting your app on k8s fast
MIT License
507 stars 59 forks source link

Updating AZ commands to work after upgrade #96

Closed erinborders closed 2 years ago

erinborders commented 2 years ago

Following an error Karen and Quentin were experiencing with the setup-gh command, I was able to reproduce it and determined that it was caused by an update to the "az ad sp" and "az ad app" commands. They no longer return "objectId" in the json response when you create, list or show them, instead they just return "id". That meant that the commands to assign roles and created FICs weren't working either because they rely on the sp and app "objectId"s

Changes:

imiller31 commented 2 years ago

Interesting did you find any documentation from the aad APIs? We should be able to link this to a public API change.

erinborders commented 2 years ago

yeah the command itself sends you to this link about the command group being migrated, which references some breaking property changes - objectId is included but there are a bunch of others too