search

Azure / durabletask

Durable Task Framework allows users to write long running persistent workflows in C# using the async/await capabilities.
Apache License 2.0
1.47k stars 287 forks source link

Change CreateTaskOrchestrationAsync tp throw OrchestrationAlreadyExistsException #1060

Closed cgillum closed 2 months ago

cgillum commented 2 months ago

This is to allow exception handling code to catch a more specific exception and differentiate between unexpected errors and expected errors.

This is largely non-breaking because OrchestrationAlreadyExistsException already derives from InvalidOperationException.

Note that the IOrchestrationServiceClient interface already documents that the CreateTaskOrchestrationAsync methods should be throwing OrchestrationAlreadyExistsException, so this change fixes the AzureStorageOrchestrationService's implementation to follow the existing spec.

cgillum commented 2 months ago

Looks like the failing CI is new and not part of our normal CIs. I think we can safely ignore its results.

davidmrdavid commented 2 months ago

@cgillum: agreed. Surprised to see it running automatically on every PR, but that's fine since it's just tests.