search

Azure / durabletask

Durable Task Framework allows users to write long running persistent workflows in C# using the async/await capabilities.
Apache License 2.0
1.47k stars 287 forks source link

Fix Argument Order in MergeTags() when Scheduling Orchestration in Entity Dispatcher #1080

Closed nytian closed 1 month ago

nytian commented 2 months ago

This PR fixes a bug where tags were incorrectly passed when entities scheduling orchestrations, causing entities to wrongly receive a SubOrchestrationInstanceCompleted message. By correcting the tag passing, this update ensures the intended fire-and-forget behavior of orchestration scheduling.

Add error handling in TaskEntityDispatcher. If there is any unexpected events received by the dispatcher, throw error indicating that this is not expected and should be an issue.

Add unit test for TaskEntityDispatcher.

nytian commented 2 months ago

I would like to add a unit test for the change I made but I didn't find a appropriate file or test class for EntityDispatcher. So I only did the E2E test. Let me know if you guys have any idea about the testing. Thanks!