search

Azure / elastic-db-tools

Elastic database tools client library allows ADO.NET developers to create applications that implement and use the pattern known as database sharding in Azure SQL Database.
MIT License
143 stars 98 forks source link

Update to Microsoft.Data.SqlClient #203

Closed michaelnero closed 4 months ago

michaelnero commented 4 years ago

Do you have any plans to migrate to Microsoft.Data.SqlClient? I'd be happy to help with the migration by opening a PR if you have a preference for how you'd want it implemented.

I have a local version where the netstandard20 target references the Microsoft.Data.SqlClient package instead of System.Data.SqlClient and with compiler directives that use the Microsoft.Data.SqlClient namespace for NETSTANDARD2_0. It works, but it required a lot of changes across quite a few files, and I'm not sure that's the direction you want to go anyway.

Let me know what your thoughts are and if I can help.

markdj commented 4 years ago

Would also like to know if there are plans for this. We need to be able to support sql always encrypted and I think this will be required to get it working. Unless there's another way to make that work with this project I'd be happy to hear it.

krish-gh commented 3 years ago

Any update on this?

FeistyMango commented 3 years ago

Would also love to see support for Microsft.Data.SqlClient as EF Core 3 now has converted to using this instead. I'm currently having to pay a double hand shake cost when invoking: Microsoft.Azure.SqlDatabase.ElasticScale.ShardManagement.ListShardMap<TKey>.OpenConnectionForKey(TKey key, string connectionString)

I am taking the connection string within the returned System.Data.SqlClient.SqlConnection object, and then constructing a Microsoft.Data.SqlClient.ConnectionString object. This also includes some fun string manipulation to inject the credentials into the connection string as well. However, the major issue here is the wasteful first call to open the connection just to obtain connection string.

FeistyMango commented 3 years ago

Seems like the work has been completed to support this and the PR has been open for a year now? Could this be merged and have an official nuget release deployed?

Pull Request - https://github.com/Azure/elastic-db-tools/pull/205

vd94 commented 3 years ago

Any update on this? Is this going to be deployed?

mcox-ng commented 3 years ago

@vd94 we gave up waiting and forked the repository along with the PR #205 and built our own package. Problem solved

mwillebrands commented 2 years ago

Any update on this?

hanssubadvies commented 1 year ago

We want to update to Microsoft.Data.SqlClient version 5.0.0. Anyone updating this code? Any alternatives other than; do not use sharding?

stuartpa commented 9 months ago

I'll bump to M.D.S 5.1.1 and release a 2.4.0-preview3 (preview2 is already M.D.S, but at 3.0.0)

stuartpa commented 9 months ago

PR to bump M.D.S to 5.1.1: #235

stuartpa commented 4 months ago

2.4.0+ released.