Azure / enterprise-azure-policy-as-code

Enterprise-ready Azure Policy-as-Code (PaC) solution (includes Az DevOps pipeline)
https://azure.github.io/enterprise-azure-policy-as-code/
MIT License
415 stars 219 forks source link

Failed deployments in the Activity log #719

Closed teemukom closed 1 month ago

teemukom commented 1 month ago

Describe the bug When running EPAC I can see failed Deployments in the activity log. The policy definitions / assignments are still correctly placed and Deploy-PolicyPlan returns no errors. The deployment error is pretty non-informative: "properties": { "statusCode": "BadRequest", "serviceRequestId": null, "statusMessage": "{\"error\":{\"code\":\"InvalidRequestContent\",\"message\":\"The deployment request content is invalid. Please see https://aka.ms/arm-deploy for usage details.\"}}", "eventCategory": "Administrative", "entity": "/providers/Microsoft.Management/managementGroups/EPAC/providers/Microsoft.Resources/deployments/pid-fe9ff1e8-5521-4b9d-ab1d-84e15447565e", "message": "Microsoft.Resources/deployments/write",

To Reproduce Deploy any change (assignment, definition, exemption) Watch the management group level action log Monitor for failed deployments

Expected behavior No failed Deployments

Screenshots image

EPAC Version v10.5.1

anwather commented 1 month ago

This could be from our telemetry, it attempts to create a deployment which will fail, we do this so our backend tools can discover the actions that users are trying to run.

https://azure.github.io/enterprise-azure-policy-as-code/#opt-out-of-telemetry-data-collection-telemetryoptout

If you set the telemetry opt out to false in global-settings.jsonc it should stop.

In terms of telemetry we simply collect that someone has executed one of the EPAC scripts, not details about what is being deployed is ever collected.

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: teemukom @.> Sent: Friday, August 2, 2024 5:07:42 PM To: Azure/enterprise-azure-policy-as-code @.> Cc: Subscribed @.***> Subject: [Azure/enterprise-azure-policy-as-code] Failed deployments in the Activity log (Issue #719)

Describe the bug When running EPAC I can see failed Deployments in the activity log. The policy definitions / assignments are still correctly placed and Deploy-PolicyPlan returns no errors. The deployment error is pretty non-informative: "properties": { "statusCode": "BadRequest", "serviceRequestId": null, "statusMessage": "{\"error\":{\"code\":\"InvalidRequestContent\",\"message\":\"The deployment request content is invalid. Please see https://aka.ms/arm-deploy for usage details.\"}}", "eventCategory": "Administrative", "entity": "/providers/Microsoft.Management/managementGroups/EPAC/providers/Microsoft.Resources/deployments/pid-fe9ff1e8-5521-4b9d-ab1d-84e15447565e", "message": "Microsoft.Resources/deployments/write",

To Reproduce Deploy any change (assignment, definition, exemption) Watch the management group level action log Monitor for failed deployments

Expected behavior No failed Deployments

Screenshots image.png (view on web)https://github.com/user-attachments/assets/6f6e11a7-8825-483c-ab72-5b69a0a9d018

EPAC Version v10.5.1

— Reply to this email directly, view it on GitHubhttps://github.com/Azure/enterprise-azure-policy-as-code/issues/719 or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACWCJVXBLDQSLVQVT4HEYBDZPMV37BFKMF2HI4TJMJ2XIZLTSSBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJLJONZXKZNENZQW2ZNLORUHEZLBMRPXI6LQMWBKK5TBNR2WLKRSG4ZDKOJYHE2DOOFENZQW2ZNJNBQXGX3MMFRGK3ECUV3GC3DVMWSHI4TVMWSG4YLNMWXHOYLUMNUF6YLDORUXM2LUPGWHG5LCNJSWG5C7OR4XAZNFJFZXG5LFUZ2G64DJMNZZHAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTGMZXGE3DEOBTHCBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGI2DINBSGM4DEMJSQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRSG4ZDKOJYHE2DOOFHORZGSZ3HMVZKMY3SMVQXIZI. You are receiving this email because you are subscribed to this thread.

Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

teemukom commented 1 month ago

Thanks for the response @anwather. Seems like this was it. Might be good to have note in the documentation.

anwather commented 1 month ago

Thanks for the response @anwather. Seems like this was it. Might be good to have note in the documentation.

Good idea.