Azure / enterprise-azureai

Unleash the power of Azure AI to your application developers in a secure & manageable way with Azure API Management and Azure Developer CLI.
MIT License
71 stars 32 forks source link

APIM Fix deploys stv2 compute platform now #50

Closed azureholic closed 4 months ago

azureholic commented 5 months ago

By introducing an explicit public IP APIM deploys in stv2 compute model Needed because stv1 is almost EOL You will have to reprovision APIM - so new AZD UP in a fresh environment

punitkshah commented 5 months ago

@azureholic - a public IP is required for the management endpoint, even when using an Internal VNET. Should we consider restricting this requirement to only "External," as suggested in the pull request?

publicIpAddressId: (virtualNetworkType == 'External') ? apimPublicIp.id : null

Please let me know if there are any additional considerations. I've currently tested this configuration with an internal VNET for APIM while working with a customer.

azureholic commented 5 months ago

I did not test with "Internal" for APIM, so I'm not sure. I do not recall the requirement for a public IP for the APIM management endpoint @pascalvanderheiden : do you know?

punitkshah commented 5 months ago

From documentation:

The public IP address resource is required when setting up the virtual network for either external or internal access. With an internal virtual network, the public IP address is used only for management operations.

I tested this with "Internal" VNET for APIM:

azureholic commented 5 months ago

You are very right @punitkshah ! I'll change the bicep. In either case (Internal or External) a public IP should be provided to force stv2. I wasn't aware, thanks for pointing this out.

pascalvanderheiden commented 4 months ago

Tested. Good to go.