search

Azure / feast-azure

Azure plugins for Feast (FEAture STore)
MIT License
81 stars 52 forks source link

Adding spark.hadoop.fs.azure properties needed for NativeAzureFileSy… #43

Closed andrijaperovic closed 2 years ago

andrijaperovic commented 2 years ago

…stem to work correctly in spark context Please see: https://github.com/Azure/feast-azure/issues/41

andrijaperovic commented 2 years ago

Can you please take a look @jainr @snowmanmsft ++ @rramani

jainr commented 2 years ago

Thanks for the contribution, can you also add an else block which tells user that they need to set those params if not found?

andrijaperovic commented 2 years ago

Thanks for the contribution, can you also add an else block which tells user that they need to set those params if not found?

@jainr i believe these are already standard feast Azure environment variables. They are referenced in the historical features python notebook.

jainr commented 2 years ago

Looks good, approving it.