Azure / feast-azure

Azure plugins for Feast (FEAture STore)
MIT License
81 stars 52 forks source link

Incorrect Redis Cache Connection string translation #59

Closed Gergues closed 2 years ago

Gergues commented 2 years ago

Hello , In using the feature online_store with the sample code form your provider example here.

With the current redis client version for Python 3.8 ( using code version as of date ) 0.3.0 https://pypi.org/project/feast-azure-provider/?msclkid=6debb6a2b9b511ec876e161bfda67531

Looks like the connection string does not exclude the default values for the Redis Cache connection string .elements Sample : myfsonlinesotre.redis.cache.windows.net:6380,password=zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz=,ssl=True,abortConnect=False

If you provide the connection string as is , Python Redis client throw exception about the abortConnect element

The only way the connection string work is by removing the ,abortConnect=False portion

Working Connection String myfsonlinesotre.redis.cache.windows.net:6380,password=zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz=,ssl=True

-George Gergues. Best of luck

Gergues commented 1 year ago

Also one note, FS does not support private link traffic to Purview .